-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-Formatted and re-organized POMs - Part 2 #479
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@hypfvieh are you available tomorrow afternoon e.g. ~15°°? I would try another merge but I may need support if it doesnt work. |
We can try it. Usually I'm at work till 4 pm, but you can try to contact me by email (address should be in the commit). |
Hi, |
jstaerk
added a commit
that referenced
this pull request
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #446.
I merged the latest upstream changes and revisited the POM configuration:
library
(that`s the root cause for broken POMs)core
module, so all submodules will create sources and javadoc jarsrelease
profile (automatically enabled by maven-release-plugin whenrelease:prepare
release:perform
is called)I tested this configuration by changing the groupId and Maven Central stuff to my personal groupId etc. For testing I disabled the
nexus-staging-maven-plugin
and disabled the broken unit tests of #478. I then checked the uploaded artifacts in Maven Central Nexus manually.All release checks of Nexus are passed now.
Something more I've noticed:
The unit tests are really old school designed. It relies on jupiter-vintage which is a compatibility layer to allow old Junit 3 and 4 style tests to be used.
These days the tests should really be JUnit 5 native tests using proper annotations, not extending "TestCase" and not using "TestSuite".
JUnit 5 offers a lot of improvements e.g. using
@ParametrizedTest
, custom test names, running tests concurrently etc.As testing is a big topic itself, I did not change anything here, but I would highly recommend think about refactoring those tests (to also get rid of forced alphabetically execution).
And one last note:
This PR includes the broken unit tests I reported in #478.
This means, this PR will not solve that issue and will only work when the unit tests are fixed.