Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix current validation errors. #482

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

langfr
Copy link
Contributor

@langfr langfr commented Sep 18, 2024

TaxCategory ws null now at a couple of tests.
Fall back to the default implementation in the interface to fill the gap.

Open failures then:

[ERROR]   LibraryTest.testMinimumProfileValidityCreditNote:280 [XPath "count(//error)" evaluated to value] expected:<[0]> but was:<[1]>
[ERROR]   LibraryTest.testMinimumProfileValidityInvoice:256 [XPath "count(//error)" evaluated to value] expected:<[0]> but was:<[1]>
    <messages>
      <error type="4" location="/*[local-name()='CrossIndustryInvoice']/*[local-name()='SupplyChainTradeTransaction']/*[local-name()='ApplicableHeaderTradeAgreement']/*[local-name()='BuyerTradeParty']/*[local-name()='SpecifiedLegalOrganization']/*[local-name()='ID']" criterion="document('FACTUR-X_MINIMUM_codedb.xml')//cl[@id=5]/enumeration[@value=$codeValue5]">Value of '@schemeID' is not allowed. from /xslt/ZF_221/FACTUR-X_MINIMUM.xslt)</error>
    </messages>

Set attribute schemeID for a LegalOrganisation only, if not minimum profile. Otherwise only the id value.

@langfr langfr mentioned this pull request Sep 18, 2024
@jstaerk jstaerk merged commit 5476b09 into ZUGFeRD:master Sep 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants