Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix for missing brrrrt #2

Closed
wants to merge 2 commits into from
Closed

Conversation

nomisum
Copy link

@nomisum nomisum commented Nov 25, 2018

removing sound curve (didnt seem to work)
increasing range and volume a bit

removing soundshading (didnt seem to work)
increasing range and volume a bit
@Zabuzard
Copy link
Owner

Thanks for the request. Is this a pure cosmetic change or does this fix issue #1 ?

The change seems to be minimal and only adjusts the range a bit. Why does it fix the issue (supposed it does)?

@Zabuzard Zabuzard self-requested a review November 25, 2018 10:00
@Zabuzard Zabuzard self-assigned this Nov 25, 2018
@Zabuzard Zabuzard added the bug label Nov 25, 2018
@nomisum
Copy link
Author

nomisum commented Nov 25, 2018

I'm not sure why it works, the actual fix is removing the brackets (last param).

Currently trying to get my head around sound shaders, trying to improve the sounds as well (no gap when full auto).

Edit: Still trying to figure out whats going on. Dont merge until further notice 😄

@nomisum
Copy link
Author

nomisum commented Nov 27, 2018

sooo i did some research:

sadly, its currently not possible to add soundshaders to plane cannons (yet). i hope this will be possible in the future, i added my sounds for tails and distance sound (muffled) to this PR already.

the used seamless sound is an edit of the original sound which doesnt have a nice tail (yet, as no sound shader). but it loops perfectly, so you can fire 2000 rounds without sound gaps.

if you prefer i could reduce this PR again to only fixing the issue (which is removing the loop param from soundBegin).

@DerZade
Copy link

DerZade commented Dec 11, 2018

I have to correct myself. Nomisums fix seems to be flawed as well.
We played yesterday a couple of hours on takistan with a few gun runs.
Most of the time with no BRRRT.

@nomisum
Copy link
Author

nomisum commented Dec 11, 2018

thats a pity. i will consider this a game bug then and come back to this when soundshaders become a thing.

@nomisum nomisum closed this Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants