Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate adding Fast-Refresh plugin into the Feliz.Template #203

Closed
Zaid-Ajaj opened this issue Jun 5, 2020 · 7 comments
Closed

Investigate adding Fast-Refresh plugin into the Feliz.Template #203

Zaid-Ajaj opened this issue Jun 5, 2020 · 7 comments

Comments

@Zaid-Ajaj
Copy link
Owner

In order to migrate the template gradually into a standalone React app instead of Elmish and only use Elmish when needed via Feliz.UseElmish library

@Zaid-Ajaj
Copy link
Owner Author

OK so my attempts aren't yielding much results 😞 if someone gives this a try and succeeds, please let us know 🙏

@aspnetde
Copy link
Contributor

If I wanted to look into it, where would I have to start?

@Shmew
Copy link
Collaborator

Shmew commented Jun 19, 2020

Here's an app using fast-refresh, webpack.config.js, package.json, hopefully that should help give you an idea. It's pretty straightforward for the most part.

aspnetde pushed a commit to aspnetde/typesafe-spa that referenced this issue Jun 26, 2020
@Zaid-Ajaj
Copy link
Owner Author

Follow up discussion on this issue from the fast-refresh plugin repository in Fable support for Feliz/React applications

@Zaid-Ajaj
Copy link
Owner Author

Almost done, waiting on two issues:

@Jmaharman
Copy link

Jmaharman commented Jan 10, 2021

Isn’t the issue with both of these problems that you can only export React components from a file if fast refresh is going to work? I.e you cannot export anything else, otherwise it cannot create the boundary and goes up the tree?

If you move those two scenarios into different files to separate them from the component, does that solve the issue?

@Zaid-Ajaj
Copy link
Owner Author

Current template supports react-refresh just fine 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants