Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Hydraation Error #10

Merged
merged 3 commits into from
Dec 17, 2023
Merged

Fix Hydraation Error #10

merged 3 commits into from
Dec 17, 2023

Conversation

Zaid-maker
Copy link
Owner

@Zaid-maker Zaid-maker commented Dec 17, 2023


Generated summary (powered by Graphite)

TL;DR

This pull request introduces a skeleton loading state for the sidebar toggle and recommended sections. This provides a better user experience by indicating that content is loading.

What changed

Two new components, ToggleSkeleton and RecommendedSkeleton, were added to the sidebar. These components display a skeleton loading state when the client is not yet ready. The Wrapper component was also updated to include these new skeleton components.

How to test

To test these changes, you can simulate a slow network connection or delay the server response. You should see the skeleton loading state in the sidebar before the actual content is loaded.

Why make this change

This change improves the user experience by providing visual feedback when content is loading. This is particularly useful in situations where network latency is high or the server response is slow.

Copy link

semanticdiff-com bot commented Dec 17, 2023

Review changes with SemanticDiff.

Analyzed 2 of 2 files.

Overall, the semantic diff is 9% smaller than the GitHub diff.

Filename Status
✔️ app/(browse)/_components/sidebar/toggle.tsx 10.0% smaller
✔️ app/(browse)/_components/sidebar/wrapper.tsx 7.69% smaller

Copy link

vercel bot commented Dec 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gamehub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2023 2:28pm

Copy link
Owner Author

@Zaid-maker Zaid-maker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DONE FIXING!

Copy link

gitstream-cm bot commented Dec 17, 2023

🥷 Code experts: no user but you matched threshold 10

Zaid-maker has most 👩‍💻 activity in the files.
Zaid-maker has most 🧠 knowledge in the files.

See details

app/(browse)/_components/sidebar/toggle.tsx

Activity based on git-commit:

Zaid-maker
DEC 53 additions & 13 deletions
NOV
OCT
SEP
AUG
JUL

Knowledge based on git-blame:
Zaid-maker: 100%

app/(browse)/_components/sidebar/wrapper.tsx

Activity based on git-commit:

Zaid-maker
DEC 26 additions & 2 deletions
NOV
OCT
SEP
AUG
JUL

Knowledge based on git-blame:
Zaid-maker: 100%

To learn more about /:\ gitStream - Visit our Docs

@Zaid-maker Zaid-maker merged commit f97573c into main Dec 17, 2023
10 checks passed
@Zaid-maker Zaid-maker deleted the fix-hyfration-error branch December 17, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant