Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Livekit Webhook #25

Merged
merged 7 commits into from
Dec 23, 2023
Merged

feat: Livekit Webhook #25

merged 7 commits into from
Dec 23, 2023

Conversation

Zaid-maker
Copy link
Owner

@Zaid-maker Zaid-maker commented Dec 22, 2023


Generated summary (powered by Graphite)

TL;DR

This pull request updates the Following and Recommended components to display the live status of users. It also modifies the getFollowedUsers and getRecommended functions in the follow-service.ts and recommended-service.ts files respectively to include the live status of users and order the results by live status and creation date.

What changed

  • In Following and Recommended components, the isLive prop of UserItem is now set to the live status of the user instead of always being true.
  • The getFollowedUsers function now includes the live status of followed users and orders the results by live status (live users first) and creation date (newest first).
  • The getRecommended function now includes the live status of recommended users and orders the results by live status (live users first) and creation date (newest first).

How to test

  • Pull the changes from this branch to your local environment.
  • Run the application and navigate to the sidebar.
  • Check the Following and Recommended sections. The live status of users should be displayed correctly.
  • Check the order of users in the Following and Recommended sections. Live users should be listed first, followed by the most recently created users.

Why make this change

This change allows users to see the live status of other users in the Following and Recommended sections, which can help them decide who to interact with. It also improves the user experience by listing live and recently created users first.

Copy link

semanticdiff-com bot commented Dec 22, 2023

Review changes with SemanticDiff.

Analyzed 5 of 5 files.

Overall, the semantic diff is 19% smaller than the GitHub diff.

Filename Status
✔️ app/(browse)/_components/sidebar/following.tsx 43.81% smaller
✔️ app/(browse)/_components/sidebar/recommended.tsx 52.82% smaller
✔️ app/api/webhooks/livekit/route.ts Analyzed
✔️ lib/follow-service.ts 16.25% smaller
✔️ lib/recommended-service.ts 31.74% smaller

Copy link

vercel bot commented Dec 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gamehub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2023 8:40am

@Zaid-maker Zaid-maker marked this pull request as ready for review December 22, 2023 23:12
Copy link

gitstream-cm bot commented Dec 22, 2023

🥷 Code experts: no user but you matched threshold 10

Zaid-maker has most 👩‍💻 activity in the files.
Zaid-maker has most 🧠 knowledge in the files.

See details

app/(browse)/_components/sidebar/following.tsx

Activity based on git-commit:

Zaid-maker
DEC 50 additions & 3 deletions
NOV
OCT
SEP
AUG
JUL

Knowledge based on git-blame:
Zaid-maker: 100%

app/(browse)/_components/sidebar/recommended.tsx

Activity based on git-commit:

Zaid-maker
DEC 52 additions & 7 deletions
NOV
OCT
SEP
AUG
JUL

Knowledge based on git-blame:
Zaid-maker: 100%

lib/follow-service.ts

Activity based on git-commit:

Zaid-maker
DEC 137 additions & 0 deletions
NOV
OCT
SEP
AUG
JUL

Knowledge based on git-blame:
Zaid-maker: 100%

lib/recommended-service.ts

Activity based on git-commit:

Zaid-maker
DEC 123 additions & 65 deletions
NOV
OCT
SEP
AUG
JUL

Knowledge based on git-blame:
Zaid-maker: 100%

To learn more about /:\ gitStream - Visit our Docs

Copy link
Owner Author

@Zaid-maker Zaid-maker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing 👏

@Zaid-maker Zaid-maker merged commit f85764d into main Dec 23, 2023
8 checks passed
@Zaid-maker Zaid-maker deleted the livekit-webhook branch December 23, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant