Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImportExport Bundle #1

Closed

Conversation

lchrusciel
Copy link

Lets clean this shit out

@lchrusciel lchrusciel force-pushed the import-export-bundle-import_job branch from 0410a10 to 726cc31 Compare July 31, 2015 14:52
$this->factory = $factory;
}

public static function getSubscribedEvents()
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing docblock.

@lchrusciel lchrusciel force-pushed the import-export-bundle-import_job branch 2 times, most recently from 50cef83 to bb50bfb Compare August 1, 2015 16:04
use Symfony\Component\Form\FormBuilderInterface;

/**
* Xls writer type.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really.

@lchrusciel lchrusciel force-pushed the import-export-bundle-import_job branch from abd4c07 to dc2ed36 Compare August 19, 2015 13:03
@lchrusciel lchrusciel force-pushed the import-export-bundle-import_job branch from 47d746c to fcf6e50 Compare August 24, 2015 13:15
@Zales0123 Zales0123 closed this Aug 28, 2015
Zales0123 pushed a commit that referenced this pull request Nov 20, 2015
Zales0123 pushed a commit that referenced this pull request Jun 14, 2016
Zales0123 pushed a commit that referenced this pull request Feb 20, 2017
[Behat] Add scenarios for adding select attribute type
Zales0123 pushed a commit that referenced this pull request Feb 24, 2017
Zales0123 pushed a commit that referenced this pull request Mar 9, 2017
Make channel pricing translatable
Zales0123 pushed a commit that referenced this pull request Aug 1, 2017
Uncaught Symfony\Component\Debug\Exception\ContextErrorException: Warning: Cannot bind closure to scope of internal class ReflectionProperty in /Users/pamil/Projects/Sylius/Sylius/var/cache/test/appTestProjectContainer.php:28784
Stack trace:
#0 [internal function]: SyliusBundleChannelBundleDoctrineORMChannelRepository_000000004a4ae55b000000001fee2e9bc41b18016a7f6458d1a51d748b49311b->__set('_entityName', NULL)
#1 /Users/pamil/Projects/Sylius/Sylius/app/TestAppKernel.php(72): ReflectionProperty->setValue(Object(SyliusBundleChannelBundleDoctrineORMChannelRepository_000000004a4ae55b000000001fee2e9bc41b18016a7f6458d1a51d748b49311b), NULL)
#2 /Users/pamil/Projects/Sylius/Sylius/app/TestAppKernel.php(41): TestAppKernel->cleanupContainer(Object(appTestProjectContainer))
#3 /Users/pamil/Projects/Sylius/Sylius/vendor/lakion/api-test-case/src/ApiTestCase.php(85): TestAppKernel->shutdown()
#4 /Users/pamil/Projects/Sylius/Sylius/vendor/phpunit/phpunit/src/Framework/TestSuite.php(727): Lakion\ApiTestCase\ApiTestCase::ensur in /Users/pamil/Projects/Sylius/Sylius/vendor/symfony/symfony/src/Symfony/Component/HttpKernel/HttpKernel.php on line 99
Zales0123 pushed a commit that referenced this pull request Feb 14, 2018
Zales0123 pushed a commit that referenced this pull request May 9, 2018
[BC BREAK] Symfony 4.0 compatibility, part #1
Zales0123 added a commit that referenced this pull request Mar 6, 2019
- desc #1
- desc #2
Zales0123 pushed a commit that referenced this pull request May 13, 2020
This PR was merged into the 1.7 branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | 1.7
| Bug fix?        | yes
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | 
| License         | MIT

Should resolve:
```bash
PHP Fatal error:  Uncaught Psalm\Exception\TypeParseTreeException: Unterminated bracket in /home/travis/build/Sylius/Sylius/vendor/vimeo/psalm/src/Psalm/Internal/Type/ParseTree.php:571
Stack trace:
#0 /home/travis/build/Sylius/Sylius/vendor/vimeo/psalm/src/Psalm/Type.php(171): Psalm\Internal\Type\ParseTree::createFromTokens(Array)
#1 /home/travis/build/Sylius/Sylius/vendor/vimeo/psalm/src/Psalm/Internal/Visitor/ReflectorVisitor.php(2668): Psalm\Type::parseTokens(Array)
#2 /home/travis/build/Sylius/Sylius/vendor/vimeo/psalm/src/Psalm/Internal/Visitor/ReflectorVisitor.php(2207): Psalm\Internal\Visitor\ReflectorVisitor->getAssertionParts('array<array-key...', Object(PhpParser\Node\Stmt\Function_))
#3 /home/travis/build/Sylius/Sylius/vendor/vimeo/psalm/src/Psalm/Internal/Visitor/ReflectorVisitor.php(323): Psalm\Internal\Visitor\ReflectorVisitor->registerFunctionLike(Object(PhpParser\Node\Stmt\Function_))
#4 /home/travis/build/Sylius/Sylius/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php(200): Psalm\Internal\Visitor\Reflect in /home/travis/build/Sylius/Sylius/vendor/vimeo/psalm/src/Psalm/Internal/Type/ParseTree.php on line 571
Fatal error: Uncaught Psalm\Exception\TypeParseTreeException: Unterminated bracket in /home/travis/build/Sylius/Sylius/vendor/vimeo/psalm/src/Psalm/Internal/Type/ParseTree.php:571
Stack trace:
#0 /home/travis/build/Sylius/Sylius/vendor/vimeo/psalm/src/Psalm/Type.php(171): Psalm\Internal\Type\ParseTree::createFromTokens(Array)
#1 /home/travis/build/Sylius/Sylius/vendor/vimeo/psalm/src/Psalm/Internal/Visitor/ReflectorVisitor.php(2668): Psalm\Type::parseTokens(Array)
#2 /home/travis/build/Sylius/Sylius/vendor/vimeo/psalm/src/Psalm/Internal/Visitor/ReflectorVisitor.php(2207): Psalm\Internal\Visitor\ReflectorVisitor->getAssertionParts('array<array-key...', Object(PhpParser\Node\Stmt\Function_))
#3 /home/travis/build/Sylius/Sylius/vendor/vimeo/psalm/src/Psalm/Internal/Visitor/ReflectorVisitor.php(323): Psalm\Internal\Visitor\ReflectorVisitor->registerFunctionLike(Object(PhpParser\Node\Stmt\Function_))
#4 /home/travis/build/Sylius/Sylius/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php(200): Psalm\Internal\Visitor\Reflect in /home/travis/build/Sylius/Sylius/vendor/vimeo/psalm/src/Psalm/Internal/Type/ParseTree.php on line 571
```

Ref. https://travis-ci.org/github/Sylius/Sylius/jobs/682877325
Ref. amphp/amp#314

<!--
 - Bug fixes must be submitted against the 1.6 or 1.7 branches (the lowest possible)
 - Features and deprecations must be submitted against the master branch
 - Make sure that the correct base branch is set
-->


Commits
-------

f6819a2 [Maintenance] Upgrade psalm version
Zales0123 added a commit that referenced this pull request Jan 28, 2022
Zales0123 added a commit that referenced this pull request Jan 28, 2022
Zales0123 added a commit that referenced this pull request Feb 3, 2022
Zales0123 pushed a commit that referenced this pull request Feb 7, 2022
…nd ApiBundle) (Zales0123)

This PR was merged into the 1.11 branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | 1.11
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | continuation of Sylius#13502
| License         | MIT



Commits
-------

50ac49c PHP 8 syntax in bundles #1
489c163 Fix line length issues
ced91b9 Typehint templating engines properly
Zales0123 added a commit that referenced this pull request Apr 29, 2022
* 1.11:
  Specify explicit priorities for all form type extensions
  Small CS fixes
  Line length fixes
  PHP 8 syntax in bundles vol.2
  Typehint templating engines properly
  Fix line length issues
  PHP 8 syntax in bundles #1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants