Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking: Add tests using zcashd test vectors #2266

Closed
6 tasks done
conradoplg opened this issue Jun 9, 2021 · 3 comments
Closed
6 tasks done

Tracking: Add tests using zcashd test vectors #2266

conradoplg opened this issue Jun 9, 2021 · 3 comments
Labels
C-enhancement Category: This is an improvement

Comments

@conradoplg
Copy link
Collaborator

conradoplg commented Jun 9, 2021

Motivation

The zcashd repository has a bunch of test vectors.

We could add tests using them to increase the confidence in zebra correctness and compatibility.

Issues

Related Work

#2215 is a subset of this issue, regarding sighashes. It raises the issue that since some test vectors are randomly generated, we may require changing zebra to accept invalid fields, which does not seem to be worth it. But it needs further investigation.

Create Sapling-only transaction v5 test vectors (#2047)
Import and test against Sinsemilla test vectors from zcash-hackworks (#2079)
Test transaction verification on block test vectors (#1378)
Move transaction test vectors into their own files (#1107)

@conradoplg conradoplg added C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage labels Jun 9, 2021
@teor2345
Copy link
Contributor

teor2345 commented Jun 9, 2021

Thanks for opening this ticket, I added a bunch of related tickets.

@mpguerra do you think this task is more like an epic? It seems like there will be a smaller task for each module or feature, with different priorities.

@mpguerra mpguerra added Epic Zenhub Label. Denotes a theme of work under which related issues will be grouped and removed S-needs-triage Status: A bug report needs triage labels Jun 15, 2021
@mpguerra mpguerra changed the title Add tests using zcashd test vectors Tracking: Add tests using zcashd test vectors Jan 27, 2022
@mpguerra mpguerra removed the Epic Zenhub Label. Denotes a theme of work under which related issues will be grouped label Jan 27, 2022
@mpguerra
Copy link
Contributor

Converted to github tracking issue

@teor2345
Copy link
Contributor

We've completed or obsoleted all these tasks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: This is an improvement
Projects
None yet
Development

No branches or pull requests

3 participants