Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use testnet blocks in the unit tests #683

Closed
1 of 4 tasks
Tracked by #2266
teor2345 opened this issue Jul 20, 2020 · 5 comments
Closed
1 of 4 tasks
Tracked by #2266

Use testnet blocks in the unit tests #683

teor2345 opened this issue Jul 20, 2020 · 5 comments
Labels
E-help-wanted Call for participation: Help is requested to fix this issue. good first issue

Comments

@teor2345
Copy link
Contributor

teor2345 commented Jul 20, 2020

At the moment, zebra-test only has mainnet test vectors.

Let's add some testnet blocks to zebra-test, and use them in the tests:

  • Add testnet blocks to zebra-test
  • Update zebra-chain tests
  • Update zebra-state tests
  • Update zebra-consensus tests

Let's use a different PR for each crate where we update the tests.

It might be helpful to have utility functions that:

  • return the genesis block data, based on the network,
  • return all the test vector block data for a network
  • return all the test vector block data, regardless of the network

It might also be helpful to re-write some of our tests to take a Network enum parameter.

@teor2345 teor2345 added Poll::Ready good first issue E-help-wanted Call for participation: Help is requested to fix this issue. labels Jul 20, 2020
@teor2345
Copy link
Contributor Author

@oxarbitrage you might be interested in doing this ticket.

@oxarbitrage
Copy link
Contributor

Will take it, thanks @teor2345

@teor2345
Copy link
Contributor Author

We've added the testnet blocks, but we still need to use them in more tests.

@teor2345 teor2345 added this to the Block Validation milestone Sep 29, 2020
@teor2345 teor2345 changed the title Add testnet blocks to zebra-test, and use them in the tests Use tesnet blocks in the unit tests Nov 24, 2020
@teor2345
Copy link
Contributor Author

No-one is working on this ticket at the moment

@dconnolly dconnolly changed the title Use tesnet blocks in the unit tests Use testnet blocks in the unit tests Dec 17, 2020
@mpguerra mpguerra removed this from the Block Validation milestone Jan 5, 2021
@mpguerra mpguerra removed the E-easy label Mar 23, 2021
@teor2345
Copy link
Contributor Author

These tests either got fixed, or they are obsolete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-help-wanted Call for participation: Help is requested to fix this issue. good first issue
Projects
None yet
Development

No branches or pull requests

4 participants