state: document memory_cache_bytes, reduce default #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #1026 Because of the way that sled uses this parameter, the actual in-memory size may be much larger. Dialing this down should help avoid high memory usage.
hdevalence
commented
Oct 29, 2020
| @@ -87,7 +96,7 @@ impl Default for Config { | |||
|
|
|||
| Self { | |||
| cache_dir, | |||
| memory_cache_bytes: 512 * 1024 * 1024, | |||
| memory_cache_bytes: 50_000_000, | |||
There was a problem hiding this comment.
This doesn't correspond to an actual in-memory size, so there's no reason to have an exact power of two size.
There was a problem hiding this comment.
It's also much easier for users to understand and tweak a default that ends with lots of zeroes.
dconnolly
reviewed
Oct 29, 2020
Comment on lines
+32
to
+36
| /// This corresponds to `sled`'s [`cache_capacity`][cc] parameter. | ||
| /// Note that the behavior of this parameter is [somewhat | ||
| /// unintuitive][gh], measuring the on-disk size of the cached data, | ||
| /// not the in-memory size, which may be much larger, especially for | ||
| /// smaller keys and values. |
teor2345
added a commit
that referenced
this pull request
Oct 30, 2020
PR #1233 changed the default `memory_cache_bytes`, but left the acceptance tests with their old value. To avoid similar issues in future, we simply divide the default by 2.
teor2345
added a commit
that referenced
this pull request
Nov 9, 2020
* Use the default memory limit in the acceptance tests PR #1233 changed the default `memory_cache_bytes`, but left the acceptance tests with their old value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1026
Because of the way that sled uses this parameter, the actual in-memory
size may be much larger. Dialing this down should help avoid high
memory usage.