network: correct parsing of reject messages #1423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 1, 2020
Not all reject messages include a data field. This change partially addresses a problem that could lead to a depleted peer set: 1. We send a response to a `getheaders` message; 2. The remote peer `reject`s our `headers` message for some reason; 3. We fail to parse their `reject` message and close the connection; 4. Repeating this process, we have no more peers. This commit fixes (3) but does not address (2).
hdevalence
force-pushed
the
reject-fix
branch
from
3cc8901 to
947685c
Compare
|
Rebased to pick up fmt fixes in #1427 |
dconnolly
approved these changes
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all reject messages include a data field. This change partially addresses
a problem that could lead to a depleted peer set:
getheadersmessage;rejects ourheadersmessage for some reason;rejectmessage and close the connection;This commit fixes (3) but does not address (2).