Downgrade tokio to 0.3.4 to avoid a time wheel panic #1453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See tokio-rs/tokio#2789 for details. We were seeing this panic during normal operation, not just at shutdown.
teor2345
added
C-bug
|
If this only happens on 0.3.5 and not on 0.3.4, then it is probably not #2789. Please submit a new bug report to Tokio. |
This bug also occurs on tokio 0.3.4, but a lot less frequently on my machine (20 minutes vs 72 hours). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
zebradpanics intokioafter syncing to the tip. See #1452 and tokio-rs/tokio#2789 for details.Solution
Downgrade
tokioto 0.3.4.I'm still testing this fix to see if it works. I've seen it happen twice in a few hours, so it should be pretty easy to work out if it is fixed.
Review
@dconnolly merged the tokio upgrade to 0.3.5 on 2020-12-02.
@hdevalence might also know if there's anything specific in 0.3.5 that we want.
This PR should be merged in the first alpha release, because the panic is pretty frequent.
Related Issues
Closes #1452.
Follow Up Work
Eventually we might want to submit a patch for tokio-rs/tokio#2789. It looks like they aren't checking the preconditions in every function that calls the underlying function that panics.