Add peer set tracing and unreachable panics #1468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
A-rust
|
Blocked on the first alpha release, due to the merge freeze |
dconnolly
approved these changes
Dec 8, 2020
rex4539
reviewed
Dec 13, 2020
This was referenced Dec 14, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The peer set code doesn't have tracing for some events, address book counts, and unexpected conditions, so it's hard to diagnose bugs like #1435
Solution
Add extra tracing and
unreachable!panics.Review
This PR should wait until after the first alpha release, because it adds new panics.
@hdevalence wrote the peer set code.
Related Issues
This PR adds diagnostics for bug #1435