Upgrade to tokio 0.3.6 from crates.io #1583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And remove the tokio git dependency patch
We're now targeting tokio 1.0, because some dependencies did not release a stable version that depends on tokio 0.3
teor2345
added
A-dependencies
dconnolly
approved these changes
Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Zebra depends on a git version of tokio, but tokio has released 0.3.6, which contains the panic fixes we need.
Solution
The code in this pull request:
Review
Anyone can review this change, but @dconnolly manages dependencies.
Let's get this change merged this week, so we can test it in the later half of the sprint.
Related Issues
Closes #1539
Follow Up Work
Remove git dependencies on Hyper, Metrics, Tower #1086