Explain why we stay connected on Inbound errors #1629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We might be syncing using this peer, so it's ok to just ignore any internal errors in their Inbound requests, and drop the request.
dconnolly
approved these changes
Jan 26, 2021
oxarbitrage
approved these changes
Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There is a single connection error case where we don't close the peer connection, without any documentation for this special case.
Solution
Add a comment:
We might be syncing using this peer, so it's ok to just ignore any internal errors in their Inbound requests, and drop the request.
Review
This review is less urgent than the hang fixes, so I'm not tagging anyone.
Related Issues
Found when implementing #1620