-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async DNS seeder lookups #1662
Async DNS seeder lookups #1662
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @oxarbitrage I've made some suggestions to help move you forward.
I've also tagged @yaahc in some questions that she's better able to answer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with this now, but I'd like @oxarbitrage to check the changes I just made.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good to me.
Motivation
I am trying to replace
to_socket_addrs()
with my crated functionresolve()
. This is work in progress for #1613.So i basically will want to replace https://github.com/oxarbitrage/zebra/blob/8a9a32b2f4f3e1e735def4ade717884885184243/zebra-network/src/config.rs#L46 with https://github.com/oxarbitrage/zebra/blob/8a9a32b2f4f3e1e735def4ade717884885184243/zebra-network/src/config.rs#L42 where
replace
is a new custom function that should return the same data.to_socket_addrs()
returnsResult<Iterator>
butreplace()
returnsOption<Iterator>
which are not the same. This can be a first issue.Additionally i think there is something else, according to some hints i got from @teor2345 in discord something like this will need to be added to the combination:
zebra/zebrad/src/components/inbound.rs
Line 257 in 4f172ab
Which makes the implementation even more complicated for my skills. Looking for some additional hints to make more progress here.
Solution
Share the problem with others.
The code in this pull request has:
Review
I will like @yaahc or @teor2345 to take a look.
Related Issues
Closes #1613
Note: #1613 is about DNS seeders, #1631 is about listener ports. This PR fixes the DNS seeders.
Follow Up Work
None by now.