Update tower-batch tests to rand 0.8 #1986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
A-dependencies
And move the ed25519-zebra patch to the workspace Cargo.toml. This fix helps avoid Cargo.lock instability.
teor2345
force-pushed
the
ed25519-zebra-workspace
branch
from
0883805 to
d128e58
Compare
dconnolly
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Zebra currently depends on a git version of ed25519-zebra in zebra-chain, but the crates.io version in the tower-batch tests.
This seems to cause some Cargo.lock instability.
Solution
Review
@dconnolly can review. This fix isn't urgent.
Related Issues
Caused by #1952.
Follow Up Work
Remove the ed25519-zebra git patch in the workspace Cargo.toml, as part of ZcashFoundation/ed25519-zebra#45.