Fix a nightly compile error by patching lexical-core to 0.7.5 #2005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lexical-core 0.7.4 is incompatible with rustc nightly >= ~2021-03-24, see rust-lang/rust#81654 While we're waiting for zcash_script, rocksdb, and their dependencies to upgrade, patch lexical-core to 0.7.5 in the zebra workspace.
teor2345
added
C-bug
5 tasks
@dconnolly @oxarbitrage if we start seeing coverage build failures, please review and merge this PR. |
Actually we pinned nightly to avoid this bug, so this fix isn't urgent. |
|
|
I fat-fingerd that close 🙈 |
dconnolly
approved these changes
Apr 15, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
lexical-core 0.7.4 is incompatible with rustc nightly > 2021-03-24, see rust-lang/rust#81654
Solution
While we're waiting for zcash_script, rocksdb, and their dependencies to
upgrade, patch lexical-core to 0.7.5 in the zebra workspace.
Review
This is urgent, because it will cause our nightly coverage CI to fail.This fix isn't urgent, because we pinned the rust version in our coverage builds.Follow Up Work
Remove the git dependency when dependent crates have updated #1086