Stop assuming there will always be a git commit #2037
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Since #1741, Zebra assumes that there will always be a
.git
directory. Even before that, Zebra assumed that there would always be some kind of git commit hash available.Solution
Enable builds where:
.git
directory.By making all
vergen
env vars optional, and skipping any env vars that don't exist.The code in this pull request has:
Manual Test Output
Cause a port/database conflict panic:
Without
.git
directory (and no google cloud git commit env var):Note that the target triple is also skipped, even though we can discover it directly from cargo. See rustyhorde/vergen#64.
With a
.git
directory:Review
This fix is urgent because the CD task is failing.
Related Issues
Caused by PR #2029.
Follow Up Work
Fix the cargo target triple and supply a better git commit version.