Add test for sighash.json test vectors #2217
Conversation
| pub script: Vec<u8>, | ||
| pub input_index: u64, | ||
| pub hash_type: u64, | ||
| pub branch_id: u64, |
There was a problem hiding this comment.
Do we want these types to be like JSON, or match Zcash?
It might be easier to just do the conversions all at once as we deserialize.
|
|
||
|
|
||
| pub static ref SIGHASH: Vec<SighashTest> = { | ||
| let json_str = include_str!("vectors/sighash.json"); |
There was a problem hiding this comment.
I'm not particularly concerned about that binary size, but I would like to avoid making Zebra's git repository 3MB larger.
How big is the JSON file when it's compressed? Can we use a compressor that's already in Zebra's transitive dependencies? (Check cargo-tree for gzip, zip, flate, lzma, zstd or something similar.)
You'll need include_bytes! for the compressed data.
conradoplg
force-pushed
the
sighash-test-vectors
branch
from
ebed04d to
06855bc
Compare
|
Closing this per sprint discussion - we need to decide if we really want to do this test, see #2215 I've also removed sighash.json from the repository since it's pretty big. We can re-add it later if needed. |
Motivation
Testing against zcashd sighash.json is useful to make sure everything works as expected.
Solution
sighash.json was added to the repo and a test that uses it.
I'm not sure if
include_str!is appropriate here (the file is 3MB)The test is currently failing, see #2215 for details. We'd need to make some adjustments, or maybe conclude that the test is not worth adding.
The code in this pull request has:
Review
This is not urgent, and we must decide if it's worth doing it in the first place.
Related Issues
Closes #2215
Follow Up Work