Update librustzcash, change zcash_history to work with it #2332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dconnolly
approved these changes
Jun 17, 2021
dconnolly
added
A-dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
librustzcash was updated and the ZIP-221 Orchard support added to its
zcash_historycrate broke our wrapper.Specifications
N/A
Designs
N/A
Solution
For now, hardcode our usage of the
Treestruct with only V1 (non-Orchard) data. In #2283 we will add proper Orchard support.Review
This blocks the ZIP-244 PRs (#2050, #2051) which need to update librustzcash.
@teor2345 might want to review this but anyone else can review it too, it's a simple change
Reviewer Checklist
Follow Up Work
#2283 will change this code to add proper Orchard support, which will be required for the other ZIP-221 PRs