Clear mempool at a network upgrade #2773
Merged
+42
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
reviewed
Sep 20, 2021
|
The issue I'm working on also needs a |
|
@conradoplg, have a look at #2785. |
|
GitHub (wrongly?) closed this when I merged #2785 🤔 |
* Clear the mempool by using a sync method * Update docs * Apply suggestions from code review Co-authored-by: teor <teor@riseup.net> * Refactor last_tip_change() * Apply suggestions from code review Co-authored-by: Janito Vaqueiro Ferreira Filho <janito.vff@gmail.com> * Fix brackets * Use best_tip_block instead of manual borrowing Co-authored-by: teor <teor@riseup.net> Co-authored-by: teor <teor@riseup.net> Co-authored-by: Janito Vaqueiro Ferreira Filho <janito.vff@gmail.com>
conradoplg
approved these changes
Sep 23, 2021
There was a problem hiding this comment.
Approving per @teor2345's comment (I also did a quick review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Zebra needs a fresh mempool at each network upgrade.
Solution
At the moment, the implementation uses
now_or_never()so thattip_change()behaves like a synchronous function. I tried other ways to approach this but to no avail.The mempool is cleared whenever
tip_change()returnsTipAction::Reset, i.e.:ChainTipChange], which is behind the current tip,Chain], also known as a rollback, andI labeled it as a draft since I'm not sure about the solution.
Closes #2761.