Manually pin Sleep futures
#2914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Sleep` type doesn't implement `Unpin` in newer versions of Tokio.
In newer Tokio versions the `Sleep` type doesn't implement `Unpin`, so it needs to be manually pinned.
jvff
force-pushed
the
pin-sleep-futures
branch
from
2aacd75 to
a21ce1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is part of the update to use Tokio version 1 (#2200), but can be merged separately.
Newer versions of Tokio have a
Sleeptype that doesn't implementUnpin, so it must be pinned before it can be polled.Solution
Two instances of
Sleepwere updated to useBox<Pin<Sleep>>so that they can be polled.Review
Anyone from the team can review this.
Reviewer Checklist
Follow Up Work