-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document chain value balances consensus rules with new format #3286
Document chain value balances consensus rules with new format #3286
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3286 +/- ##
==========================================
- Coverage 77.13% 77.13% -0.01%
==========================================
Files 265 265
Lines 31342 31342
==========================================
- Hits 24177 24176 -1
- Misses 7165 7166 +1 |
It's #3209, I updated the PR description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to be careful that we don't confuse transaction fees (the remaining transaction value) and transparent outputs (the spendable transparent value).
Co-authored-by: teor <teor@riseup.net>
I think this is ready but i don't have admin merge privileges so enabled auto merge for when someone approves. |
Hopefully the build bot will fix this too. |
Motivation
We want to change the doc of this rules to follow a new format standard for easier consensus rule searching in Zebra.
Close #3221
Close #3219
Close #3220
Additionally the consensus rule about the transparent value pool inside the transaction itself was also updated
(this does not have an open issue as far as i know)Close #3209
Solution
As we implement the chain value balances rules in the same function i decided to document all together in a single PR.
Review
Anyone can review, no code is changed.