1. Fix some address crawler timing issues #3293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
P-Medium
C-security
This was referenced Dec 24, 2021
Codecov Report
@@ Coverage Diff @@
## main #3293 +/- ##
==========================================
- Coverage 77.25% 77.23% -0.03%
==========================================
Files 265 265
Lines 31380 31445 +65
==========================================
+ Hits 24244 24287 +43
- Misses 7136 7158 +22 |
3 tasks
|
Bumping this up to high priority, because this fixes some occasional CI failures, and it might conflict with other PRs. |
teor2345
added
the
I-integration-fail
|
I've tested this PR locally, and the crawler and address book metrics look a lot better. The number of peer addresses rises rapidly, and gets full after a few hours. And Zebra doesn't hang any more, even after a few days. |
teor2345
force-pushed
the
fix-address-crawler-timing
branch
from
efd6bb0 to
fa44edf
Compare
dconnolly
reviewed
Jan 4, 2022
dconnolly
reviewed
Jan 4, 2022
dconnolly
reviewed
Jan 4, 2022
dconnolly
reviewed
Jan 4, 2022
Comment on lines
+991
to
+993
| // If the heartbeat is delayed, also delay all future heartbeats. | ||
| // (Shorter heartbeat intervals just add load, without any benefit.) | ||
| interval.set_missed_tick_behavior(tokio::time::MissedTickBehavior::Delay); |
dconnolly
reviewed
Jan 4, 2022
Comment on lines
+425
to
+433
| Message::Block(block) => format!( | ||
| "block {{ height: {}, hash: {} }}", | ||
| block | ||
| .coinbase_height() | ||
| .as_ref() | ||
| .map(|h| h.0.to_string()) | ||
| .unwrap_or_else(|| "None".into()), | ||
| block.hash(), | ||
| ), |
dconnolly
reviewed
Jan 4, 2022
Comment on lines
+82
to
+94
| // Display heights for single-block responses (which Zebra requests and expects) | ||
| Response::Blocks(blocks) if blocks.len() == 1 => { | ||
| let block = blocks.first().expect("len is 1"); | ||
| format!( | ||
| "Block {{ height: {}, hash: {} }}", | ||
| block | ||
| .coinbase_height() | ||
| .as_ref() | ||
| .map(|h| h.0.to_string()) | ||
| .unwrap_or_else(|| "None".into()), | ||
| block.hash(), | ||
| ) | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Zebra's address crawler is fragile - small changes can cause significant regressions.
This PR deals with a few different sources of that instability.
Solution
Connectionawaiting request state machineReview
This PR is ready for review.
Let's assign a reviewer when people are back from leave.
Reviewer Checklist
I've tested this PR locally, and the crawler and address book metrics look a lot better. The number of peer addresses rises rapidly, and gets full after a few hours. And Zebra doesn't hang any more, even after a few days.
It's hard to test this PR, because the timing issues are subtle, and don't show up in some network environments. We should have better tests after we implement #1592.