Replace tempdir dependency with tempfile
#3337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce repeated code and make it easier to change from using `tempdir` to use `tempfile` instead.
Use `tempfile`'s `TempDir` instead.
Reduce repeated code and make it easier to upgrade to `tempfile`.
Replace obsoleted `tempdir` dependency with `tempfile`.
Replace obsoleted `tempdir` dependency with `tempfile`.
Update it now that `tempdir` has been replaced with `tempfile`.
Ban duplicate versions of the `tempdir` dependency.
It apparently isn't needed anymore.
Codecov Report
@@ Coverage Diff @@
## main #3337 +/- ##
==========================================
- Coverage 77.85% 77.82% -0.04%
==========================================
Files 266 266
Lines 31447 31449 +2
==========================================
- Hits 24484 24476 -8
- Misses 6963 6973 +10 |
39 tasks
37 tasks
35 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
tempdiris unmaintained and obsoleted bytemfile.Solution
Change crates to depend on
tempfileinstead oftempdir. Usetempfile::TempDirwheretempdir::TempDirwas once used. This required changes to either not have a prefix to the temporary name, or to use thetempfile::Builderto add a prefix. Finally, thetempdirexception indeny.tomlwas removed.An
infernoexception indeny.tomlwas also removed, as it seems like it's not needed anymore.This closes #2985.
Review
Anyone can review this low priority PR.
Reviewer Checklist
Follow Up Work