Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(doc): Clarify inbound and outbound port requirements #5584

Merged
merged 1 commit into from
Nov 8, 2022
Merged

fix(doc): Clarify inbound and outbound port requirements #5584

merged 1 commit into from
Nov 8, 2022

Conversation

teor2345
Copy link
Collaborator

@teor2345 teor2345 commented Nov 8, 2022 •
edited by dconnolly
Loading

Motivation

We want to document all the ports that Zebra requires.

Review

@gustavovalverde asked about this.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
  • How do you know it works? Does it have tests?

@teor2345 teor2345 added C-bug Category: This is a bug A-docs Area: Documentation P-Medium ⚡ I-usability Zebra is hard to understand or use labels Nov 8, 2022
@teor2345 teor2345 requested a review from a team as a code owner November 8, 2022 19:00
@teor2345 teor2345 self-assigned this Nov 8, 2022
@teor2345 teor2345 requested review from dconnolly and removed request for a team November 8, 2022 19:00
@dconnolly dconnolly added the C-enhancement Category: This is an improvement label Nov 8, 2022
mergify bot added a commit that referenced this pull request Nov 8, 2022
@mergify
Merge of #5584
91c65f2
@mergify mergify bot mentioned this pull request Nov 8, 2022
Closed
@mergify mergify bot merged commit 4c3f04e into main Nov 8, 2022
@mergify mergify bot deleted the clarify-ports branch November 8, 2022 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dconnolly dconnolly dconnolly approved these changes

@gustavovalverde gustavovalverde gustavovalverde approved these changes

Assignees

@teor2345 teor2345

Labels
A-docs Area: Documentation C-bug Category: This is a bug C-enhancement Category: This is an improvement I-usability Zebra is hard to understand or use
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@teor2345 @dconnolly @gustavovalverde