Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(script): updates search-issue-refs to group references by issue and output markdown #6444

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

arya2
Copy link
Contributor

@arya2 arya2 commented Apr 1, 2023

Motivation

It's more convenient to view all references to a closed issue at once.

Solution

  • Group references by issue
  • Only output issue ids and permalinks to where they were found in the repo

Review

This is optional priority, anyone can review.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

@arya2 arya2 added C-enhancement Category: This is an improvement C-cleanup Category: This is a cleanup P-Optional ✨ A-script Area: Script handling labels Apr 1, 2023
@arya2 arya2 self-assigned this Apr 1, 2023
@arya2 arya2 requested a review from a team as a code owner April 1, 2023 00:18
@arya2 arya2 requested review from dconnolly and removed request for a team April 1, 2023 00:18
@github-actions github-actions bot added the C-bug Category: This is a bug label Apr 1, 2023
@arya2 arya2 removed the request for review from dconnolly April 1, 2023 00:58
@codecov
Copy link

codecov bot commented Apr 1, 2023

Codecov Report

Merging #6444 (4a5ba21) into main (5db2243) will increase coverage by 0.17%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6444      +/-   ##
==========================================
+ Coverage   77.78%   77.95%   +0.17%     
==========================================
  Files         304      304              
  Lines       39637    39637              
==========================================
+ Hits        30833    30901      +68     
+ Misses       8804     8736      -68     

Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is better, thanks for adjusting it. Just an issue with the permalink that i think we should change but it maybe has a reason i am not seeing. Feel free to clarify and merge.

zebra-utils/src/bin/search-issue-refs/main.rs Show resolved Hide resolved
mergify bot added a commit that referenced this pull request Apr 12, 2023
@mergify mergify bot merged commit 2908acf into main Apr 12, 2023
@mergify mergify bot deleted the fix-search-issue-refs branch April 12, 2023 03:08
@arya2 arya2 mentioned this pull request Apr 18, 2023
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-script Area: Script handling C-bug Category: This is a bug C-cleanup Category: This is a cleanup C-enhancement Category: This is an improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants