Delete outdated TODOs refering to closed issues
#6732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpguerra
added
A-docs
mpguerra
commented
May 19, 2023
mpguerra
commented
May 19, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6732 +/- ##
==========================================
- Coverage 77.98% 77.98% -0.01%
==========================================
Files 308 308
Lines 40869 40872 +3
==========================================
- Hits 31873 31872 -1
- Misses 8996 9000 +4 |
teor2345
previously approved these changes
May 21, 2023
Co-authored-by: teor <teor@riseup.net>
Co-authored-by: teor <teor@riseup.net>
…ownloads Co-authored-by: teor <teor@riseup.net>
…o fix Co-authored-by: teor <teor@riseup.net>
…o change in future Co-authored-by: teor <teor@riseup.net>
Co-authored-by: teor <teor@riseup.net>
|
Rustfmt is failing after the changes: https://github.com/ZcashFoundation/zebra/actions/runs/5043379478/jobs/9045106343?pr=6732 |
teor2345
reviewed
May 23, 2023
teor2345
reviewed
May 23, 2023
teor2345
reviewed
May 23, 2023
teor2345
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to clean up any code comments relating to
TODOtasks that have already been addressed.Specifications
Complex Code or Requirements
Solution
Deletes comments related to issues that have been closed as fixed.
Depends-On: #6737
Review
For each deleted comment the reviewer should double check that the PR really addresses the issue which is mentioned in the code comment.
Informational comments that refer to closed issues should not be removed unless they are no longer relevant.
Reviewer Checklist
Follow Up Work
This is just a first pass. There are still a number of issues that have been closed as
wont-fixreferenced in the code and we should decide what we do about those.Depends-