Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(docs): Add private IP address known issue to README #6783

Merged
merged 1 commit into from
May 29, 2023

Conversation

teor2345
Copy link
Contributor

Motivation

We want to stop using private IP addresses by default in Zebra (#3117), but we might not have time to do it before the first stable release.

Solution

Add it as a known issue to the readme

Review

This is a low priority doc update

Do we also want to add a note about private IPs to the next release changelog, or the stable release changelog?

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

@teor2345 teor2345 added A-docs Area: Documentation P-Low ❄️ I-privacy Zebra discloses private information labels May 29, 2023
@teor2345 teor2345 requested a review from a team as a code owner May 29, 2023 21:02
@teor2345 teor2345 self-assigned this May 29, 2023
@teor2345 teor2345 requested review from dconnolly and removed request for a team May 29, 2023 21:02
@github-actions github-actions bot added C-enhancement Category: This is an improvement C-feature Category: New features labels May 29, 2023
mergify bot added a commit that referenced this pull request May 29, 2023
mergify bot added a commit that referenced this pull request May 29, 2023
@mergify mergify bot merged commit 7b6ccee into main May 29, 2023
@mergify mergify bot deleted the readme-private-ips branch May 29, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: Documentation C-enhancement Category: This is an improvement C-feature Category: New features I-privacy Zebra discloses private information
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants