Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(actions): do not require the get-disk-name job for forks #8988

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

gustavovalverde
Copy link
Member

Motivation

Some PRs can't be merged as a new job was added which requires acccess to variables are not available from a fork repo, for example:

Solution

  • Add this job to the .patch-external.yml workflow
  • This job was also missing from the .patch.yml which could cause issue in other instances not related to forks

Follow-up Work

Allow external PRs to be tested without avoiding to run these jobs

PR Author's Checklist

  • The PR name will make sense to users.
  • The PR provides a CHANGELOG summary.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

PR Reviewer's Checklist

  • The PR Author's checklist is complete.
  • The PR resolves the issue.

@gustavovalverde gustavovalverde added C-bug Category: This is a bug A-devops Area: Pipelines, CI/CD and Dockerfiles I-integration-fail Continuous integration fails, including build and test failures P-Critical 🚑 labels Nov 4, 2024
@gustavovalverde gustavovalverde self-assigned this Nov 4, 2024
@gustavovalverde gustavovalverde requested a review from a team as a code owner November 4, 2024 10:31
@gustavovalverde gustavovalverde requested review from oxarbitrage and removed request for a team November 4, 2024 10:31
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Nov 4, 2024
Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lets try it out, ill request the Zaino people to update to main after this gets merged in.

mergify bot added a commit that referenced this pull request Nov 5, 2024
@mergify mergify bot merged commit d7fbde3 into main Nov 5, 2024
99 checks passed
@mergify mergify bot deleted the fix-ci-fork branch November 5, 2024 12:30
@oxarbitrage oxarbitrage mentioned this pull request Nov 5, 2024
7 tasks
@arya2 arya2 mentioned this pull request Dec 5, 2024
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-bug Category: This is a bug C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG I-integration-fail Continuous integration fails, including build and test failures P-Critical 🚑
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants