Skip to content
This repository has been archived by the owner on Jan 21, 2022. It is now read-only.

Fix NuGet package format #309

Merged
merged 2 commits into from
Sep 20, 2017
Merged

Fix NuGet package format #309

merged 2 commits into from
Sep 20, 2017

Conversation

qmfrederik
Copy link
Contributor

#308 will make this fix obsolete.

The NuGet packages produced by Vlc.DotNet are invalid. The assemblies are located in lib\{TFM}\AnyCPU\, but the NuGet specifications do not allow for an AnyCPU subfolder. Instead, the libraries should just go in lib\{TFM}.

I hit this on Visual Studio 2017; perhaps newer NuGet versions are a bit more strict about the folder structure.

This PR fixes that.

Fixes #276
Obsoletes #300
Fixes NuGet/Home#4417
Fixes NuGet/Home#4259
Fixes NuGet/Home#5678

@jeremyVignelles
Copy link
Collaborator

Can you reproduce #276 ? I am still unable to reproduce this and merging this will cause conflicts when merging #308 . I think #308 will be merged soon, so that won't be necessary.

@qmfrederik
Copy link
Contributor Author

Yes, I can reproduce #276, that's why I created this PR. I'd be happy to rebase #308 if/when this gets merged - this kind of is blocking me at the moment.

@jeremyVignelles
Copy link
Collaborator

Can we talk on gitter?

@jeremyVignelles jeremyVignelles merged commit 6c5fe10 into ZeBobo5:develop Sep 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.