This repository has been archived by the owner on Jan 21, 2022. It is now read-only.
Support playing videos from Stream objects #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var versionString = this.VlcVersion; | ||
| versionString = versionString.Split('-', ' ')[0]; | ||
|
|
||
| var version = new Version(versionString); |
There was a problem hiding this comment.
I think we need to do that in many places. Could you move that in a property?
|
Great work, as always. I let you check my comment and apply changes as needed. Feel free to come on gitter if you want to discuss about it |
|
@jeremyVignelles Sure - I added a |
This was referenced Sep 22, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #207 with some patches applied. I've kept the original commit; if you'd rather have the original author amend his PR that's also fine with me.
This adds support for playing videos based on .NET Stream objects. It requires VLC 3.0.
Changes w.r.t. #207:
byte[]array every timeCallbackReadMediais called. This has a fairly important performance impact.Streamdoes not have to be seekable