-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs #34
Add docs #34
Conversation
NOTE: Migration from |
4cb2476
to
fb48a9f
Compare
Ah, right. What do I do with the old docs that are bunched up in README? Do I try to slim it down? |
Now that I think about it, let's not merge this yet. I'd like to actually document the system calls, too. |
@atirut-w Thanks for your help on that! Feel free to poke me for any further detail about the implementation or when this draft becomes ready to review For the syscalls, the |
It's just that the readme only tell you the name, but doesn't go into enough details for some of the more specific syscalls like |
@Zeal8bit I'd like a review of the convention I used to document the system calls with ( |
Also did a little formatting to make tables consistent
Put together with VFS docs due to their relations
a1b3647
to
345e562
Compare
New status: proofreading and feedback pending :) |
- `A` - 0 if successful, otherwise an error code | ||
- `BC` - The number of bytes read | ||
|
||
## `write` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to separate the syscalls in a nice way? Can we integrate raw HTML code?
Does mkdocs
allow us to make custom class for a markdown block?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lot of customization you can do. IIRC there are detail HTML tags and horizontal bars in markdown, and Material for MkDocs provide a lot of their own stuff. Not quite sure which one to use, though.
@atirut-w Thanks a lot for your contribution! I love the design of the doc, I think you can integrate an automated task to deploy the pages. I only left a single comment for the separating the syscalls but nothing very important |
Indeed. I even made my own GH Action for it, but I'm not sure if it would be scope creep for this PR or if you would want to host it somewhere else other than GH Pages. |
Thanks for your contribution, merging it! |
The docs can be deployed to GH Pages by running
mkdocs gh-deploy
. A workflow to automatically regen and deploy docs can be added, but I have not done it yet on this PR (feel free to ask tho).