Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs #34

Merged
merged 13 commits into from
Oct 6, 2024
Merged

Add docs #34

merged 13 commits into from
Oct 6, 2024

Conversation

atirut-w
Copy link
Contributor

The docs can be deployed to GH Pages by running mkdocs gh-deploy. A workflow to automatically regen and deploy docs can be added, but I have not done it yet on this PR (feel free to ask tho).

@atirut-w
Copy link
Contributor Author

NOTE: Migration from README.md will start later.

@atirut-w atirut-w force-pushed the docs branch 3 times, most recently from 4cb2476 to fb48a9f Compare July 31, 2024 02:31
@atirut-w atirut-w marked this pull request as ready for review July 31, 2024 02:41
@atirut-w
Copy link
Contributor Author

Ah, right. What do I do with the old docs that are bunched up in README? Do I try to slim it down?

@atirut-w atirut-w marked this pull request as draft July 31, 2024 09:23
@atirut-w
Copy link
Contributor Author

Now that I think about it, let's not merge this yet. I'd like to actually document the system calls, too.

@Zeal8bit
Copy link
Owner

@atirut-w Thanks for your help on that! Feel free to poke me for any further detail about the implementation or when this draft becomes ready to review

For the syscalls, the README explains them from the user application perspective, not driver/kernel perspective, if you think it would make sense to have another sections/chapter/part for that part, or even a subsection in driver part, feel free to add it

@atirut-w
Copy link
Contributor Author

For the syscalls, the README explains them from the user application perspective, not driver/kernel perspective, if you think it would make sense to have another sections/chapter/part for that part, or even a subsection in driver part, feel free to add it

It's just that the readme only tell you the name, but doesn't go into enough details for some of the more specific syscalls like mount, directory operations, time format, etc. Now that there's a dedicated place for docs, I feel like it would be a disservice not to elaborate on them.

@atirut-w
Copy link
Contributor Author

atirut-w commented Aug 2, 2024

@Zeal8bit I'd like a review of the convention I used to document the system calls with (docs/system-calls.md). If they're okay, I can go ahead and do the rest.

@atirut-w atirut-w force-pushed the docs branch 3 times, most recently from a1b3647 to 345e562 Compare September 28, 2024 08:39
@atirut-w atirut-w marked this pull request as ready for review September 28, 2024 08:43
@atirut-w
Copy link
Contributor Author

New status: proofreading and feedback pending :)

- `A` - 0 if successful, otherwise an error code
- `BC` - The number of bytes read

## `write`
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to separate the syscalls in a nice way? Can we integrate raw HTML code?
Does mkdocs allow us to make custom class for a markdown block?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot of customization you can do. IIRC there are detail HTML tags and horizontal bars in markdown, and Material for MkDocs provide a lot of their own stuff. Not quite sure which one to use, though.

@Zeal8bit
Copy link
Owner

@atirut-w Thanks a lot for your contribution! I love the design of the doc, I think you can integrate an automated task to deploy the pages.

I only left a single comment for the separating the syscalls but nothing very important

@atirut-w
Copy link
Contributor Author

I think you can integrate an automated task to deploy the pages.

Indeed. I even made my own GH Action for it, but I'm not sure if it would be scope creep for this PR or if you would want to host it somewhere else other than GH Pages.

@Zeal8bit
Copy link
Owner

Zeal8bit commented Oct 6, 2024

Thanks for your contribution, merging it!

@Zeal8bit Zeal8bit merged commit 59bf5fe into Zeal8bit:main Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants