Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MacOS Build Support #35

Merged
merged 1 commit into from
Aug 8, 2024
Merged

MacOS Build Support #35

merged 1 commit into from
Aug 8, 2024

Conversation

zoul0813
Copy link
Contributor

@zoul0813 zoul0813 commented Aug 2, 2024 •
edited
Loading

  • add detected_OS in Makefile
  • add Darwin support for stat

Requires brew install make (ie; GNU Make v4+, MacOS ships with GNU Make 3)
Use gmake in place of make on MacOS

Zeal8bit
Zeal8bit reviewed Aug 3, 2024
View reviewed changes
Copy link
Owner

@Zeal8bit Zeal8bit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your PR, this will help Mac users!

I confirm your changes work on my Ubuntu computer.

Makefile Show resolved Hide resolved
target/zeal8bit/unit.mk Outdated Show resolved Hide resolved
@zoul0813 zoul0813 marked this pull request as ready for review August 8, 2024 14:08
@zoul0813
* add detected_OS in Makefile
0e73688 
* add Darwin support for `stat`
@Zeal8bit Zeal8bit merged commit ca17566 into Zeal8bit:main Aug 8, 2024
@zoul0813 zoul0813 deleted the macos-build branch August 8, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zeal8bit Zeal8bit Zeal8bit left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zoul0813 @Zeal8bit