Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misinformation #3

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix misinformation #3

wants to merge 2 commits into from

Conversation

ger3tto
Copy link

@ger3tto ger3tto commented Aug 25, 2024

I just noticed that MultiDiscrete would throw you errors if you actually imported it and used, because the init.py of the action parser folder names the discrete setting into "DiscreteAction", not "MultiDiscrete"

@ZealanL
Copy link
Owner

ZealanL commented Aug 25, 2024

I just noticed that MultiDiscrete would throw you errors if you actually imported it and used, because the init.py of the action parser folder names the discrete setting into "DiscreteAction", not "MultiDiscrete"

This is because it is called DiscreteAction... which is what the guide says.

This does not make sense.
The action parser named DiscreteAction is multi-discrete, as the guide states.
If you try to use it, you will be using a multi-discrete action parser, which is not what the guide suggests. The guide warns against this.
Instead of suggesting a revision to my phrasing of this warning, your PR entirely removes this warning from the guide. Why?

I will remove the code formatting from MultiDiscrete in the guide to make sure it is clear that this is not the name of a class that exists, sorry if that confused you.

ZealanL added a commit that referenced this pull request Aug 25, 2024
This addresses the confusion that presumably caused #3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants