-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address naught write detection #111
Conversation
Made a new PR as I pushed some new irrelevant commits to the old one (which was from master). |
Thanks Y_Less, this is surely a useful feature to have. And thanks for the comprehensive documentation, appreciate it. I've merged this locally with some minor formatting corrections in README (I hope you don't mind) and with a fix to enable the address_naught test in order to make it run together with the other tests when using On a side note, I noticed today that the long call detection test (long_call_ok) sometimes fails on my machine (Intel i5-7500) with the default setting of 5000, but 10000 works pretty stable. I wonder if this might be the case for other users and if it might be necessary to increase the default. What do you think? |
Adds detection for writing to address 0 (not always an error) and flags to control it.:
This also cleaned up some other register uses.