Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with recent changes #128

Merged
merged 6 commits into from
Aug 2, 2024
Merged

Sync with recent changes #128

merged 6 commits into from
Aug 2, 2024

Conversation

Y-Less
Copy link
Contributor

@Y-Less Y-Less commented Dec 31, 2023

I had a fork for a few fixes that have proven stable, this is just to merge them back to the main branch because the situation is confusing for absolutely everybody!

  • 63 character max function names. This doesn't affect code with shorter limits, since 63>31, but allows the plugin to work better on open.mp with its higher limits.
  • Fix a problem with the stack being clobbered when displaying errors in some code. This only happened when the code itself did weird illegal things with the stack, but it shouldn't cause the plugin to crash.
  • Merged @AmyrAhmady's CI support.
  • Reduced the frequency at which long call checks are done (to never in -d0), since they don't need to be precise to the instruction and it actually had a noticeable impact on performance. I know performance isn't a primary concern here, but this is a free win.

Y-Less and others added 6 commits August 26, 2023 18:38
Use a copy of the AMX struct instead of a few preserved values.

Check long calls only on `BREAK` statements.  It's far less likely to conflict with other code by mangling the stack that way.

Move the long call checks inside the debug existence checks.

Use the top of the heap, not the bottom.
@Zeex Zeex merged commit 4dadaf8 into Zeex:master Aug 2, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants