-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smoothing interpolators: pair production (atomic nucleus and electron), log-log splines #5
Open
lynntf
wants to merge
22
commits into
Zelenyy:master
Choose a base branch
from
lynntf:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a material is made of more than one material, it used to multiply the energies by the scaling factors erroneously. The check was implemented for the single material case, not the multiple material case.
Correct mixture calculation of energy
Some other changes have been made:
|
'xcom' : ["data/NIST_XCOM.hdf5","data/PeriodicTableofElements.csv"],
Update setup.py
Another note based on #7, computation of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behavior for interpolation with pair production does not appear to use a correct linearization function for the data. Although this seems to be an accurate reproduction of the available XCOM software and what is explained in the XCOM documents, the interpolation is not behaving as it should.
Consider the output of the following using the current code (adapted from the XCOM example notebook):
Notice the large fluctuations near the pair production energy thresholds.
nist-calculators/xcom
code.These are not equivalent, but similar. However, both seem to be incorrect for creating a linear log-log plot for the log-log interpolation.
The normalizing function appears to have been mistaken at some point and the corrected linearizing function implemented now is$\left(E (E - E')\right)^{-3} \sigma_{\mathrm{PAIR}}(E)$ . Perhaps at some point this was written as $\sigma_{\mathrm{PAIR}}(E)/E^3/(E - E')^3$ and incorrectly interpreted as $\sigma_{\mathrm{PAIR}}(E)/\left(E^3/(E - E')^3\right)$ , but it is not clear.
Additional changes were made to the boundary condition types for the interpolators (allowing for linear extrapolation in the log-log domain;
bc_type='natural'
) along with some other linting changes and some more explicit code.