Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: zeroize Point and BigInt on drop, and other zeroize changes #154

Closed
wants to merge 9 commits into from
Closed

Fix: zeroize Point and BigInt on drop, and other zeroize changes #154

wants to merge 9 commits into from

Commits on Nov 9, 2021

  1. feat: Impl Zeroize for Point<E>

    added test and use case of Zeroizing<Point>
    nskybytskyi committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    c0b9f17 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2021

  1. fix: zeroizing Point<E> objects that need to be zeroized

    (cherry picked from commit e90ee50)
    DmytroTym authored and nskybytskyi committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    60fc579 View commit details
    Browse the repository at this point in the history
  2. nit: zeroize can multiply BigInt by 0 instead of BigInt::zero()

    (cherry picked from commit db57eee)
    nskybytskyi committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    6d7bf6c View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2021

  1. fix: zeroize num-bigint properly

    (suggested by @survvived and @elichai)
    nskybytskyi committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    8a65bde View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2021

  1. fix!: delete implementation of Zeroize for gmp BigInt

    Note: actual contents of gmp bigint are zeroized on drop within gmp, so it does not make sense to zeroize them by hand.
    nskybytskyi committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    db978ec View commit details
    Browse the repository at this point in the history
  2. feat: zeroize num-bigint on drop.

    Note: I had to tweak the implementation of zeroize a bit once again, to get past borrow checker. I believe it still does the same thing, and it still passes my tests, but feel free to double-check.
    nskybytskyi committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    059ceaf View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2021

  1. Configuration menu
    Copy the full SHA
    4e725c0 View commit details
    Browse the repository at this point in the history
  2. fix!: make sure to pass Scalar<E> by reference.

    Note: as pointed out by @survived, passing Scalars by value will create an extra copy on the stack. Several methods and functions were updated to take a reference instead.
    nskybytskyi committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    fd2099c View commit details
    Browse the repository at this point in the history
  3. fix: make sure to clone Scalar<E> when constructing structs.

    Note: as pointed out by @DmytroTym and @survived, moving Scalars into structs will create an extra copy on the stack. Several struct constructions were updated to clone instead.
    nskybytskyi committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    2ebb91a View commit details
    Browse the repository at this point in the history