-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: zeroize Point and BigInt on drop, and other zeroize changes #154
Commits on Nov 9, 2021
-
feat: Impl Zeroize for Point<E>
added test and use case of Zeroizing<Point>
Configuration menu - View commit details
-
Copy full SHA for c0b9f17 - Browse repository at this point
Copy the full SHA c0b9f17View commit details
Commits on Nov 15, 2021
-
fix: zeroizing Point<E> objects that need to be zeroized
(cherry picked from commit e90ee50)
Configuration menu - View commit details
-
Copy full SHA for 60fc579 - Browse repository at this point
Copy the full SHA 60fc579View commit details -
nit: zeroize can multiply BigInt by 0 instead of BigInt::zero()
(cherry picked from commit db57eee)
Configuration menu - View commit details
-
Copy full SHA for 6d7bf6c - Browse repository at this point
Copy the full SHA 6d7bf6cView commit details
Commits on Nov 16, 2021
-
fix: zeroize num-bigint properly
(suggested by @survvived and @elichai)
Configuration menu - View commit details
-
Copy full SHA for 8a65bde - Browse repository at this point
Copy the full SHA 8a65bdeView commit details
Commits on Nov 17, 2021
-
fix!: delete implementation of Zeroize for gmp BigInt
Note: actual contents of gmp bigint are zeroized on drop within gmp, so it does not make sense to zeroize them by hand.
Configuration menu - View commit details
-
Copy full SHA for db978ec - Browse repository at this point
Copy the full SHA db978ecView commit details -
feat: zeroize num-bigint on drop.
Note: I had to tweak the implementation of zeroize a bit once again, to get past borrow checker. I believe it still does the same thing, and it still passes my tests, but feel free to double-check.
Configuration menu - View commit details
-
Copy full SHA for 059ceaf - Browse repository at this point
Copy the full SHA 059ceafView commit details
Commits on Nov 22, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 4e725c0 - Browse repository at this point
Copy the full SHA 4e725c0View commit details -
fix!: make sure to pass Scalar<E> by reference.
Note: as pointed out by @survived, passing Scalars by value will create an extra copy on the stack. Several methods and functions were updated to take a reference instead.
Configuration menu - View commit details
-
Copy full SHA for fd2099c - Browse repository at this point
Copy the full SHA fd2099cView commit details -
fix: make sure to clone Scalar<E> when constructing structs.
Note: as pointed out by @DmytroTym and @survived, moving Scalars into structs will create an extra copy on the stack. Several struct constructions were updated to clone instead.
Configuration menu - View commit details
-
Copy full SHA for 2ebb91a - Browse repository at this point
Copy the full SHA 2ebb91aView commit details