Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ecosystem refactoring #83

Closed
fabienjuif opened this issue Nov 3, 2017 · 7 comments
Closed

ecosystem refactoring #83

fabienjuif opened this issue Nov 3, 2017 · 7 comments
Assignees
Milestone

Comments

@fabienjuif
Copy link
Member

This issue trace the strategy of refactoring for this two issues:

  • Documentation
  • Lerna uses

The workflow I would like to see is this one:

  • 1 standby PR, this like a master, should be named refactoring - protected
    • We can't commit in this PR, we should use branches and PR
    • We will rebase merge it to master when it will be stable and OK for us
  • n PR to complete the two issues above
    • Will be squash merge into the refactoring - protected PR
    • Will be named after this convention : <emoji> <text> (#pr) (1 emoji, and the text should be lowercase)

FYI: @frinyvonnick

@frinyvonnick
Copy link
Collaborator

Remaining work on lerna :

  • Set up publishing logic
  • Don't forget to copy root LICENSE and README.md in hoc-react-loader package when publishing

@fabienjuif
Copy link
Member Author

  • Move to lerna
  • Move to yarn workspaces
  • Try to move to microbundle

@fabienjuif fabienjuif added this to the 7.0.0 milestone Oct 10, 2018
@fabienjuif fabienjuif mentioned this issue Oct 12, 2018
7 tasks
@fabienjuif
Copy link
Member Author

@frinyvonnick Why should we move LICENSE in each package ? It seems that npmjs look into package.json to retrieve the license

@frinyvonnick
Copy link
Collaborator

Babel seems to have only one LICENSE file but repeat the license acronym in each package.json, we maybe should find other examples ?

@fabienjuif
Copy link
Member Author

What I try to say is:

  1. I think this is necessary to add it to each package.json, and I think this is the case?
  2. I think this is NOT necessary to copy the whole LICENSE file in each package, what is your though?

@frinyvonnick
Copy link
Collaborator

frinyvonnick commented Oct 17, 2018

I agree with the two statements 👍

@fabienjuif
Copy link
Member Author

Thank you,
=> I close the issue
=> Both packages have LICENSE field :)

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants