🔨 yarn workspaces #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabienjuif
requested review from
bpetetot,
ptitFicus,
frinyvonnick,
delphinemillet and
guillaumecrespel
and removed request for
bpetetot
| this.setState({ | ||
| loaded: !this.state.loaded, | ||
| }) | ||
| this.setState(state => ({ |
There was a problem hiding this comment.
Why are you using setState this way ? The other one is shorter.
There was a problem hiding this comment.
Because I rely on previous state value.
This way I am sure that I have the last state when the setState take place.
Functional setState is better than object IMO
| @@ -117,7 +117,7 @@ export default ( | |||
| render() { | |||
| const { props } = this.state | |||
| if (isInError(this.props, this.state, this.context)) { | |||
| return <ErrorIndicator {...props} /> | |||
| return ErrorIndicator === undefined ? null : <ErrorIndicator {...props} /> | |||
There was a problem hiding this comment.
Using the code below doesn't work?
ErrorIndicator && <ErrorIndicator {...props} />There was a problem hiding this comment.
Yeah... I don't know what happens 😱
There was a problem hiding this comment.
Ho I see right know why I did this:
- react render nothing if you return
nullbut notundefined
frinyvonnick
approved these changes
Oct 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #92
fixes #91
related to #83
TODOs
coreandfull