Add comments and suggestions #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+225
to
+229
| if (position_setpoint > STR_MAX_ANGLE) position_setpoint = STR_MAX_ANGLE; // STR_MAX_ANGLE should be +135 | ||
| if (position_setpoint < STR_MIN_ANGLE) position_setpoint = STR_MIN_ANGLE; // STR_MIN_ANGLE should be -135 | ||
|
|
||
| if (position_setpoint > STR_MAX_ANGLE) position_setpoint = STR_MAX_ANGLE; | ||
| if (position_setpoint < STR_MIN_ANGLE) position_setpoint = STR_MIN_ANGLE; | ||
| if (angle > STR_MAX_ANGLE) angle = STR_MAX_ANGLE; // STR_MAX_ANGLE should be +135 | ||
| if (angle < STR_MIN_ANGLE) angle = STR_MIN_ANGLE; // STR_MIN_ANGLE should be -135 |
There was a problem hiding this comment.
This is important to reduce the error accumulation of the PI integrator. If the values entering the PI are not in the same range/scale, it will cause a bias on the error variable, which can end up being unfixable in runtime, since we never reset the integrator.
Comment on lines
+292
to
+294
| if (measurements.batvoltage_avg_sum_count++ > ULONG_MAX -1) { | ||
| average_measurements() | ||
| } |
There was a problem hiding this comment.
here we prevent the overflow, although it would not happen even in a million years
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.