addressing coderabbit review comments

Zeral-Zhang · Jan 9, 2025 · b62fecb · b62fecb
1 parent 7c30ebe
commit b62fecb
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/app/client/packages/design-system/ads/src/List/List.stories.tsx b/app/client/packages/design-system/ads/src/List/List.stories.tsx
@@ -60,8 +60,12 @@ const items = [
 export const ListStory = ListTemplate.bind({}) as StoryObj;
 ListStory.storyName = "List";
 ListStory.args = {
-  children: items.map((item, index) => (
-    <ListItem key={index} {...item} onClick={() => alert("Clicked")} />
+  children: items.map((item) => (
+    <ListItem
+      key={`item-${item.title}`}
+      {...item}
+      onClick={() => alert("Clicked")}
+    />
   )),
 };
 

diff --git a/...ages/design-system/ads/src/Templates/EntityExplorer/EntityGroupsList/EntityGroupsList.tsx b/...ages/design-system/ads/src/Templates/EntityExplorer/EntityGroupsList/EntityGroupsList.tsx
@@ -52,12 +52,12 @@ const EntityGroup = <T,>({ group }: { group: EntityGroupProps<T> }) => {
       key={group.groupTitle}
     >
       <List className={group.className} groupTitle={group.groupTitle}>
-        {updatedGroup.items.map((item: T) =>
+        {updatedGroup.items.map((item: T, index) =>
           group.renderList ? (
             group.renderList(item)
           ) : (
             <ListItem
-              key={(item as ListItemProps)?.title}
+              key={(item as ListItemProps)?.title || `item-${index}`}
               {...(item as ListItemProps)}
             />
           ),