Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Port of additional music moods (#4968) #4982

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Birdulon
Copy link
Contributor

Rework war calculations, add war2, winning, losing music moods related to higher combat levels and large attrition ratios, respectively. Rework dynamic transition logic to accomodate more than just peace<->war.
This is a considerable refactor of my additions of my personal widget linked in #4968, which forked in June 2020. It is nowhere near as used and tested as that, but should be a little bit nicer than it by the end.

@sprunk
Copy link
Member

sprunk commented Oct 6, 2023

Splitting off as many small standalone changes as possible into commits would be helpful, a monolith is a bit harder to review.

@GoogleFrog
Copy link
Contributor

That might not be necessary. We could just replace one black box with another - that sounds easier. It's relatively safe to do with a widget as I could just run it for a month and see if anything comes up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants