Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added shieldball healthbars widget #5211

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

danfireman
Copy link
Contributor

@danfireman danfireman commented Mar 9, 2024

image

I've put "enabled by default" but:

  • I haven't done extensive performance checking, but a couple of hundred shields didn't cause an FPS drop I could detect.

  • Like any means of displaying information, it is putting stuff in the UI which could get in the way of seeing other important things and it's visually slightly noisy. If merged enabled it should probably have a UI setting to turn it off again, but I'm not going to work on that unless requested (energy levels permitting).

author = "dyth68",
date = "2024",
license = "PD", -- should be compatible with Spring
layer = 11,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why 11?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because copypaste, change to whatever you wish.

@GoogleFrog
Copy link
Contributor

I think I will have to run this locally for a bit.

@danfireman
Copy link
Contributor Author

The opacity, size and position of the healthbars are probably things to tweak. Also how much they should change size by zoom level.

@danfireman
Copy link
Contributor Author

@GoogleFrog : I've been using this for the last couple of months and it's been extremely useful.

Any progress on your evaluation?

@GoogleFrog
Copy link
Contributor

GoogleFrog commented May 22, 2024

I was stuck arguing on the internet about licenses for a while, and was quite busy before that, but should now have time to run it.

@GoogleFrog
Copy link
Contributor

It looks like the visual is hidden until I do /luaui reload, so I have barely seen it.

@GoogleFrog
Copy link
Contributor

image
This picture doesn't make any sense.

https://zero-k.info/Battles/Detail/1931178

@danfireman
Copy link
Contributor Author

I had apparently made a very important update I forgot to push which actually refreshes the list of shielded units. This explains both your observations.

Now pushed. 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants