Skip to content

Commit

Permalink
Remove commons-lang3 from the dependencies
Browse files Browse the repository at this point in the history
  • Loading branch information
ZeroOne3010 committed Aug 2, 2018
1 parent 1062d76 commit 82ffb9b
Show file tree
Hide file tree
Showing 30 changed files with 68 additions and 101 deletions.
5 changes: 0 additions & 5 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,6 @@
<artifactId>jackson-databind</artifactId>
<version>2.9.6</version>
</dependency>
<dependency>
<groupId>org.apache.commons</groupId>
<artifactId>commons-lang3</artifactId>
<version>3.7</version>
</dependency>

<dependency>
<groupId>org.junit.jupiter</groupId>
Expand Down
28 changes: 23 additions & 5 deletions src/main/java/com/github/zeroone3010/yahueapi/State.java
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,14 @@
import com.fasterxml.jackson.annotation.JsonInclude;
import com.fasterxml.jackson.annotation.JsonInclude.Include;
import com.fasterxml.jackson.annotation.JsonProperty;
import org.apache.commons.lang3.builder.EqualsBuilder;
import org.apache.commons.lang3.builder.ToStringBuilder;
import com.fasterxml.jackson.core.JsonProcessingException;
import com.fasterxml.jackson.databind.ObjectMapper;

import java.awt.Color;
import java.util.ArrayList;
import java.util.Collections;
import java.util.List;
import java.util.Objects;
import java.util.Optional;

@JsonInclude(Include.NON_NULL)
Expand Down Expand Up @@ -179,8 +180,21 @@ private static double gammaCorrection(float component) {
}

@Override
public boolean equals(Object obj) {
return EqualsBuilder.reflectionEquals(this, obj);
public boolean equals(final Object o) {
if (this == o) return true;
if (o == null || getClass() != o.getClass()) return false;
final State state = (State) o;
return Objects.equals(on, state.on) &&
Objects.equals(hue, state.hue) &&
Objects.equals(sat, state.sat) &&
Objects.equals(bri, state.bri) &&
Objects.equals(ct, state.ct) &&
Objects.equals(xy, state.xy);
}

@Override
public int hashCode() {
return Objects.hash(on, hue, sat, bri, ct, xy);
}

private static final class XAndYAndBrightness {
Expand All @@ -207,7 +221,11 @@ int getBrightness() {

@Override
public String toString() {
return ToStringBuilder.reflectionToString(this);
try {
return new ObjectMapper().writeValueAsString(this);
} catch (final JsonProcessingException e) {
throw new RuntimeException(e);
}
}
}
}
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
package com.github.zeroone3010.yahueapi.domain;

import org.apache.commons.lang3.builder.ToStringBuilder;
import org.apache.commons.lang3.builder.ToStringStyle;

import java.util.List;

public class Action {
Expand Down Expand Up @@ -90,6 +87,6 @@ public void setColormode(String colormode) {

@Override
public String toString() {
return ToStringBuilder.reflectionToString(this, ToStringStyle.SHORT_PREFIX_STYLE);
return JsonStringUtil.toJsonString(this);
}
}
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
package com.github.zeroone3010.yahueapi.domain;

import org.apache.commons.lang3.builder.ToStringBuilder;
import org.apache.commons.lang3.builder.ToStringStyle;

public class ApiInitializationError {
private int type;
private String address;
Expand Down Expand Up @@ -34,6 +31,6 @@ public void setDescription(String description) {

@Override
public String toString() {
return ToStringBuilder.reflectionToString(this, ToStringStyle.SHORT_PREFIX_STYLE);
return JsonStringUtil.toJsonString(this);
}
}
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
package com.github.zeroone3010.yahueapi.domain;

import org.apache.commons.lang3.builder.ToStringBuilder;
import org.apache.commons.lang3.builder.ToStringStyle;

public class ApiInitializationStatus {
private ApiInitializationError error;
private ApiInitializationSuccess success;
Expand All @@ -25,6 +22,6 @@ public void setSuccess(ApiInitializationSuccess success) {

@Override
public String toString() {
return ToStringBuilder.reflectionToString(this, ToStringStyle.SHORT_PREFIX_STYLE);
return JsonStringUtil.toJsonString(this);
}
}
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
package com.github.zeroone3010.yahueapi.domain;

import org.apache.commons.lang3.builder.ToStringBuilder;
import org.apache.commons.lang3.builder.ToStringStyle;

public class ApiInitializationSuccess {
private String username;

Expand All @@ -16,6 +13,6 @@ public void setUsername(String username) {

@Override
public String toString() {
return ToStringBuilder.reflectionToString(this, ToStringStyle.SHORT_PREFIX_STYLE);
return JsonStringUtil.toJsonString(this);
}
}
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
package com.github.zeroone3010.yahueapi.domain;

import com.fasterxml.jackson.annotation.JsonProperty;
import org.apache.commons.lang3.builder.ToStringBuilder;
import org.apache.commons.lang3.builder.ToStringStyle;

import java.util.Map;

Expand Down Expand Up @@ -68,6 +66,6 @@ public class BridgeConfig {

@Override
public String toString() {
return ToStringBuilder.reflectionToString(this, ToStringStyle.SHORT_PREFIX_STYLE);
return JsonStringUtil.toJsonString(this);
}
}
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
package com.github.zeroone3010.yahueapi.domain;

import org.apache.commons.lang3.builder.ToStringBuilder;
import org.apache.commons.lang3.builder.ToStringStyle;

public class ComponentSoftwareUpdate {
private String state;
private String lastinstall;
Expand All @@ -25,6 +22,6 @@ public void setLastinstall(String lastinstall) {

@Override
public String toString() {
return ToStringBuilder.reflectionToString(this, ToStringStyle.SHORT_PREFIX_STYLE);
return JsonStringUtil.toJsonString(this);
}
}
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
package com.github.zeroone3010.yahueapi.domain;

import com.fasterxml.jackson.annotation.JsonProperty;
import org.apache.commons.lang3.builder.ToStringBuilder;
import org.apache.commons.lang3.builder.ToStringStyle;

public class ConfigBackup {
@JsonProperty("status")
Expand All @@ -12,6 +10,6 @@ public class ConfigBackup {

@Override
public String toString() {
return ToStringBuilder.reflectionToString(this, ToStringStyle.SHORT_PREFIX_STYLE);
return JsonStringUtil.toJsonString(this);
}
}
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
package com.github.zeroone3010.yahueapi.domain;

import com.fasterxml.jackson.annotation.JsonProperty;
import org.apache.commons.lang3.builder.ToStringBuilder;
import org.apache.commons.lang3.builder.ToStringStyle;

public class ConfigSoftwareUpdate {
@JsonProperty("updatestate")
Expand All @@ -20,6 +18,6 @@ public class ConfigSoftwareUpdate {

@Override
public String toString() {
return ToStringBuilder.reflectionToString(this, ToStringStyle.SHORT_PREFIX_STYLE);
return JsonStringUtil.toJsonString(this);
}
}
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
package com.github.zeroone3010.yahueapi.domain;

import com.fasterxml.jackson.annotation.JsonProperty;
import org.apache.commons.lang3.builder.ToStringBuilder;
import org.apache.commons.lang3.builder.ToStringStyle;

public class ConfigSoftwareUpdate2 {
@JsonProperty("checkforupdate")
Expand All @@ -18,6 +16,6 @@ public class ConfigSoftwareUpdate2 {

@Override
public String toString() {
return ToStringBuilder.reflectionToString(this, ToStringStyle.SHORT_PREFIX_STYLE);
return JsonStringUtil.toJsonString(this);
}
}
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
package com.github.zeroone3010.yahueapi.domain;

import com.fasterxml.jackson.annotation.JsonProperty;
import org.apache.commons.lang3.builder.ToStringBuilder;
import org.apache.commons.lang3.builder.ToStringStyle;

public class ConfigSoftwareUpdate2AutoInstall {
@JsonProperty("updatetime")
Expand All @@ -12,6 +10,6 @@ public class ConfigSoftwareUpdate2AutoInstall {

@Override
public String toString() {
return ToStringBuilder.reflectionToString(this, ToStringStyle.SHORT_PREFIX_STYLE);
return JsonStringUtil.toJsonString(this);
}
}
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
package com.github.zeroone3010.yahueapi.domain;

import com.fasterxml.jackson.annotation.JsonProperty;
import org.apache.commons.lang3.builder.ToStringBuilder;
import org.apache.commons.lang3.builder.ToStringStyle;

public class ConfigSoftwareUpdate2Bridge {
@JsonProperty("state")
Expand All @@ -12,6 +10,6 @@ public class ConfigSoftwareUpdate2Bridge {

@Override
public String toString() {
return ToStringBuilder.reflectionToString(this, ToStringStyle.SHORT_PREFIX_STYLE);
return JsonStringUtil.toJsonString(this);
}
}
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
package com.github.zeroone3010.yahueapi.domain;

import com.fasterxml.jackson.annotation.JsonProperty;
import org.apache.commons.lang3.builder.ToStringBuilder;
import org.apache.commons.lang3.builder.ToStringStyle;

import java.util.List;

Expand All @@ -16,6 +14,6 @@ public class DeviceTypes {

@Override
public String toString() {
return ToStringBuilder.reflectionToString(this, ToStringStyle.SHORT_PREFIX_STYLE);
return JsonStringUtil.toJsonString(this);
}
}
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
package com.github.zeroone3010.yahueapi.domain;

import com.fasterxml.jackson.annotation.JsonProperty;
import org.apache.commons.lang3.builder.ToStringBuilder;
import org.apache.commons.lang3.builder.ToStringStyle;

public class EntertainmentStream {
@JsonProperty("proxymode")
Expand All @@ -16,6 +14,6 @@ public class EntertainmentStream {

@Override
public String toString() {
return ToStringBuilder.reflectionToString(this, ToStringStyle.SHORT_PREFIX_STYLE);
return JsonStringUtil.toJsonString(this);
}
}
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
package com.github.zeroone3010.yahueapi.domain;

import com.fasterxml.jackson.annotation.JsonProperty;
import org.apache.commons.lang3.builder.ToStringBuilder;
import org.apache.commons.lang3.builder.ToStringStyle;

import java.util.List;
import java.util.Map;
Expand Down Expand Up @@ -102,6 +100,6 @@ public void setLocations(Map<String, List<Integer>> locations) {

@Override
public String toString() {
return ToStringBuilder.reflectionToString(this, ToStringStyle.SHORT_PREFIX_STYLE);
return JsonStringUtil.toJsonString(this);
}
}
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
package com.github.zeroone3010.yahueapi.domain;

import com.fasterxml.jackson.annotation.JsonProperty;
import org.apache.commons.lang3.builder.ToStringBuilder;
import org.apache.commons.lang3.builder.ToStringStyle;

public class GroupState {
@JsonProperty("all_on")
Expand All @@ -28,6 +26,6 @@ public void setAnyOn(boolean anyOn) {

@Override
public String toString() {
return ToStringBuilder.reflectionToString(this, ToStringStyle.SHORT_PREFIX_STYLE);
return JsonStringUtil.toJsonString(this);
}
}
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
package com.github.zeroone3010.yahueapi.domain;

import com.fasterxml.jackson.annotation.JsonProperty;
import org.apache.commons.lang3.builder.ToStringBuilder;
import org.apache.commons.lang3.builder.ToStringStyle;

public class InternetServices {
@JsonProperty("internet")
Expand All @@ -16,6 +14,6 @@ public class InternetServices {

@Override
public String toString() {
return ToStringBuilder.reflectionToString(this, ToStringStyle.SHORT_PREFIX_STYLE);
return JsonStringUtil.toJsonString(this);
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
package com.github.zeroone3010.yahueapi.domain;

import com.fasterxml.jackson.core.JsonProcessingException;
import com.fasterxml.jackson.databind.ObjectMapper;

final class JsonStringUtil {
private static final ObjectMapper objectMapper = new ObjectMapper();

private JsonStringUtil() { /* prevent */ }

static String toJsonString(final Object object) {
try {
return objectMapper.writeValueAsString(object);
} catch (final JsonProcessingException e) {
throw new RuntimeException(e);
}
}
}
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
package com.github.zeroone3010.yahueapi.domain;

import com.fasterxml.jackson.annotation.JsonProperty;
import org.apache.commons.lang3.builder.ToStringBuilder;
import org.apache.commons.lang3.builder.ToStringStyle;

import java.util.Map;

Expand Down Expand Up @@ -128,6 +126,6 @@ public void setConfig(LightConfig config) {

@Override
public String toString() {
return ToStringBuilder.reflectionToString(this, ToStringStyle.SHORT_PREFIX_STYLE);
return JsonStringUtil.toJsonString(this);
}
}
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
package com.github.zeroone3010.yahueapi.domain;

import org.apache.commons.lang3.builder.ToStringBuilder;
import org.apache.commons.lang3.builder.ToStringStyle;

public class LightConfig {
private String archetype;
private String function;
Expand Down Expand Up @@ -34,6 +31,6 @@ public void setDirection(String direction) {

@Override
public String toString() {
return ToStringBuilder.reflectionToString(this, ToStringStyle.SHORT_PREFIX_STYLE);
return JsonStringUtil.toJsonString(this);
}
}
Loading

0 comments on commit 82ffb9b

Please sign in to comment.