Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Overleaf-compatible doc class #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

luorix1
Copy link

@luorix1 luorix1 commented Jul 2, 2024

Minor changes to doc class to allow direct compatibility with Overleaf without any errors.
Simply need to replace import statement for doc class "snu-ece-bsc-thesis" -> "snu-ece-bsc-thesis-pdftex".

@Zeta611
Copy link
Owner

Zeta611 commented Jul 2, 2024

Thank you for the contribution!
Can you add sample pdfs (both English and Korean versions) made from the new class?

@Zeta611
Copy link
Owner

Zeta611 commented Jul 2, 2024

Also, it would be best to modify necessary parts with the mechanism here:

%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
% XeLaTeX or LuaLaTeX required %
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
\RequirePackage{iftex}
\ifXeTeX\else\ifLuaTeX\else
\ClassError {snu-ece-bsc-thesis}
{ This~class~only~supports~XeLaTeX~and~LuaLaTeX. }
{ Please~use~either~XeLaTeX~or~LuaLaTeX. }
\fi\fi

You can use \ifpdftex to check if it is using the pdfLaTeX engine, and add necessary modifications.

@luorix1
Copy link
Author

luorix1 commented Jul 2, 2024

Ok! I'll see if I can appy the changes in the next 2 days or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants