Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builder Sequential Fix #890

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Builder Sequential Fix #890

merged 2 commits into from
Feb 6, 2025

Conversation

supersergiy
Copy link
Member

No description provided.

@supersergiy supersergiy requested a review from nkemnitz February 6, 2025 05:20
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8e6a908) to head (2bec508).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #890   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          142       142           
  Lines         6100      6102    +2     
=========================================
+ Hits          6100      6102    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@nkemnitz nkemnitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing that one!
I think disallowing parallel build for nontrivial objects broke coverage for the parallel part of a non-parallel build? Or is that code now just unreachable?

for obj in stage.parallel_part:
obj_result = _build_object(
fn=obj.fn,
kwargs=obj.kwargs,
spec=obj.spec,
name_prefix=obj.name_prefix,
)
_process_result(obj, obj_result)



@pytest.fixture
def file_io_funcitons():
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def file_io_funcitons():
def file_io_functions():

@supersergiy
Copy link
Member Author

Fixed! Indeed, there is no more parallel_part in sequential stages, as the parallel part doesn't respect list order.

@supersergiy supersergiy force-pushed the sergiy/builder_sequential_fix branch from 935d281 to 6eb7d1c Compare February 6, 2025 16:36
@supersergiy supersergiy requested a review from nkemnitz February 6, 2025 16:50
@supersergiy supersergiy force-pushed the sergiy/builder_sequential_fix branch from 6eb7d1c to 2bec508 Compare February 6, 2025 22:15
@supersergiy supersergiy merged commit 6f212bb into main Feb 6, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants