-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Builder Sequential Fix #890
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #890 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 142 142
Lines 6100 6102 +2
=========================================
+ Hits 6100 6102 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing that one!
I think disallowing parallel build for nontrivial objects broke coverage for the parallel part of a non-parallel build? Or is that code now just unreachable?
zetta_utils/zetta_utils/builder/building.py
Lines 154 to 161 in 935d281
for obj in stage.parallel_part: | |
obj_result = _build_object( | |
fn=obj.fn, | |
kwargs=obj.kwargs, | |
spec=obj.spec, | |
name_prefix=obj.name_prefix, | |
) | |
_process_result(obj, obj_result) |
tests/unit/test_builder.py
Outdated
|
||
|
||
@pytest.fixture | ||
def file_io_funcitons(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def file_io_funcitons(): | |
def file_io_functions(): |
Fixed! Indeed, there is no more |
935d281
to
6eb7d1c
Compare
6eb7d1c
to
2bec508
Compare
No description provided.