feat: use tinybrain for image downsampling #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #894 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 142 142
Lines 6102 6104 +2
=========================================
+ Hits 6102 6104 +2 ☔ View full report in Codecov by Sentry. |
nkemnitz
reviewed
Feb 6, 2025
zetta_utils/tensor_ops/common.py
Outdated
| @@ -388,7 +388,7 @@ def interpolate( # pylint: disable=too-many-locals | |||
| allow_slice_rounding=allow_slice_rounding, | |||
| ) | |||
|
|
|||
| if mode == "segmentation" and ( | |||
| if mode in ("segmentation", "img", "bilinear") and ( | |||
There was a problem hiding this comment.
It's not going to break things, but tinybrain has no C implementation for signed integer type averaging (e.g. our image encodings). Normally don't need to downsample these - only for misalignment detection.
If I read it correctly, tinybrain will convert such cases to fp32 and use numpy based interpolation, which is probably slower than torch+CUDA
There was a problem hiding this comment.
Addressed via seung-lab/tinybrain#22
nkemnitz
reviewed
Feb 6, 2025
supersergiy
force-pushed
the
sergiy/use_tinybrain_for_img_downs
branch
from
fb57c5a to
14ab282
Compare
nkemnitz
approved these changes
Feb 7, 2025
supersergiy
force-pushed
the
sergiy/use_tinybrain_for_img_downs
branch
from
14ab282 to
9cbdff5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #737